add filter pens that decompose components #3460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
decomposed components with flipping transform have their path direction reversed, possibly causing dropouts if they overlap other components; this option ensures they will get reversed as they are decomposed (similar to what ufo2ft DecomposeComponentsFilter or Glyphs.app does when decomposing flipped components). Also we allow specific instances of to set skipMissingComponents differently from the class default value, and add an alias to MissingComponentError so one doesn't need to import it explicitly but can the pen's class attribute.
anthrotype
force-pushed
the
decompose-filter-pen
branch
from
10bf92d
to
34150c3
Compare
anthrotype
force-pushed
the
decompose-filter-pen
branch
from
34150c3
to
f15857c
Compare
|
Does this really need to be a class? It sounds trivial / no-op: |
|
I know, I added it mostly because 1) we already have a DecomposingRecordingPen (segment-oriented) and 2) to be able to test the DecomposingPen mixin class (which can't be instantiated on its own). It's one line, I'd just keep it. |
|
from this PR, I'm mostly interested in the DecomposingFilterPointPen (which allows me to selectively decompose specific components, optionally not recurse in nested comps, reverse direction for flipped ones, optionally skip missing, etc., removing some of the same logic that is currently in ufo2ft). |
|
SGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a bunch of filter and recording pens to do composite glyph decomposition (I need to use them for some ufo2ft filter).