Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds infrastructure for merging name tables. A stylistic set feature params are newly merged as a result (the feature names are joined into one name).
The way this is currently designed:
--merge-names
switch, the system names (ID < 256) are merged during name table merging.Is this approach reasonable? The name record visitor seems to take quite time for some fonts. The whole pre- and post-merge could be made opt-in behind the new switch, however, the layout merging would need to have access to the options during
mergeFeature
to know not to create any feature params. Alternatively, the name strings could be stored somewhere else and not on the objects where they are referred from.The usage is demonstrated on
mergeFeatureParams
, however currently implemented for ss features only, not the others.(also the original
NameRecordVisitor
was fixed to mark all names indicated byFirstParamUILabelNameID
andNumNamedParameters
as seen, not just the first name ID)