Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feaLib] Apply avar also to variable locations #3043

Merged
merged 5 commits into from
Mar 16, 2023
Merged

[feaLib] Apply avar also to variable locations #3043

merged 5 commits into from
Mar 16, 2023

Conversation

madig
Copy link
Contributor

@madig madig commented Mar 15, 2023

Follow-up to #3042.

  1. Guard against missing avar entries when normalizing condition set locations
  2. Apply avar also to variable locations

Closes #3040.

@madig madig added the feaLib label Mar 15, 2023
@madig madig changed the title Fealib more avar Apply avar also to variable locations Mar 15, 2023
@anthrotype anthrotype merged commit 5abdd83 into main Mar 16, 2023
@anthrotype anthrotype deleted the fealib-more-avar branch March 16, 2023 12:35
@anthrotype anthrotype changed the title Apply avar also to variable locations [feaLib] Apply avar also to variable locations Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

Assignees
No one assigned
Labels
feaLib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ConditionSets and VariableScalars should have avar applied to coordinates
2 participants
@madig @anthrotype