Add typing to pens #2936
Open
Add typing to pens #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madig
force-pushed
the
type-pens
branch
2 times, most recently
from
eb47341
to
facf2dc
Compare
|
@madig Can you comment on how merging this may impact things that aren't font tools that use the base pens? |
|
It shouldn't impact any users. I kept the argument names unchanged, but added e.g. the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This an alternative to #2919 where I just apply the typing but keep the argument names the same. They could be changed in a separate PR.
This took way too long. In the process, I actually added arguments to methods like
identifier, as they were missing in places. I had to take some liberties with# type: ignore, usually around the special qCurve case ofNonebeing the last point. I also ignore variousaddComponentcases where the keyword for an argument doesn't match the abstract class. I left someXXXcomments in, for subsequent clean-up. I suppose mypy is stumbling over the, uh, organic design of various pens.For review, I tried to batch the changes by what they're used for, singling out the Cu2Qu pens because I thought they might need a more careful look. WxPen seems weird to me, as the code before probably didn't work? There are no tests, so I looked at the wx API docs.