set codecov to not fail_ci_if_error #2928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov keeps failing to upload the coverage report seemingly at random, e.g. https://github.com/fonttools/fonttools/actions/runs/3686952402/jobs/6240048994#step:8:40 I thought I had already fixed it by setting a CODECOV_TOKEN in the repo secrets with #2763 but it still keeps pestering us so I think the only option left is to not have the PR checks fail with codecov errors.
|
hm I'm not 100% sure but it might be a github "feature" that the repository's secrets such as CODECOV_TOKEN are not available from pull requests such as one early on (#2927) from @cmyr who was contributing for the first time and is not currently an org member? I can see that codecov managed to find its token from the environment variables in this PR of mine, unlike with his.. https://github.com/fonttools/fonttools/actions/runs/3687224978/jobs/6240526409#step:8:34 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codecov keeps failing to upload the coverage report seemingly at random, e.g.
https://github.com/fonttools/fonttools/actions/runs/3686952402/jobs/6240048994#step:8:40
I thought I had already fixed it by setting a CODECOV_TOKEN in the repo secrets with #2763
but it still keeps pestering us so I think the only option left is to not have the PR checks fail with codecov errors.