Replace master word in designspace document files
#2904
Conversation
| # locations. It's a miniature designspace. | ||
| # Remember the "name" attribute we assigned to the sources? | ||
| glyphData['masters'] = [ | ||
| dict(font="master.thin", | ||
| glyphData['sources'] = [ |
There was a problem hiding this comment.
Here you may need to change the matching code that expects this dictionary key
There was a problem hiding this comment.
are you suggesting to change the occurrences of glyphData['masters'] with glyphData['sources'] in Lib/fontTools/designspaceLib/* source files?
There was a problem hiding this comment.
Yes basically, however I'm not familiar with that part of the designspace spec, maybe @LettError and others can advise. I think maybe font editors who rely on the format would need updating as well if the key changes from "masters" to "sources", that is, code outside this repository would need to adapt. But I'm not sure 100%.
|
I don't think there are any tools left that need these glyph-specific designspaces. |
This PR is an attempt to fix some
masterword entries infonttools/Doc/source/directory files.Please review this PR and do suggest if needed any changes.
This PR is created to fix issue #2896