Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify user expectations for getStatNames #2892

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clarify user expectations for getStatNames #2892

wants to merge 2 commits into from

Conversation

madig
Copy link
Contributor

@madig madig commented Nov 16, 2022

Closes #2890

anthrotype
anthrotype approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, though maybe we could also mention something along the same lines in the designspace xml docs, in addition to these inlined docstrings?

@belluzj
Copy link
Contributor

belluzj commented Nov 18, 2022

In the XML docs we should mention the name attributes on instances are no longer mandatory if you have STAT info in the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype Awaiting requested review from anthrotype

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@madig @belluzj @anthrotype