Avar2

[behdad]

No description provided.

[anthrotype]

what's the status of this?

[behdad]

what's the status of this?

Needs rework. I ported avar to otData, which breaks the old API. Need to add a compatibility layer in between. Also to figure out how to expose the avar2 portion.

[behdad]

This PR so far moves avar parsing to otData and keeps previous API. No handcoded API is added for the avar2 part and that part can be accessed through the .table mechanism. Since that involves a variationStore, I feel like this is enough of an abstraction. WDYT @anthrotype?

[anthrotype]

in COLR table module, we do something similar for handling COLRv1 via otData converters but keep the pre-existing interface to not break existing tools.
https://github.com/fonttools/fonttools/blob/main/Lib/fontTools/ttLib/tables/C_O_L_R_.py

Though I didn't make COLR a subclass of BaseTTXConverter, but called OTTableReader/Writer directly and don't keep a table attribute around for the old version's API, only for the new otData-driven one. The reasoning was to avoid having two duplicate or out-of-sync sources of truth for the data i.e. the low level table and the higher-lever constructs from the old API.

But maybe it's fine like you did here.

[behdad]

I added a test. It doesn't test fromXML or check what toXML produces but tests the rest.

[behdad]

Added fromXML as well.