New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support variable feature syntax #2432
Merged
simoncozens
merged 22 commits into
fonttools:main
from
simoncozens:variable-feature-syntax
Oct 28, 2021
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
6810cf5
Parse variable scalars in feature files.
simoncozens 3fd6358
Build variable scalars for anchors/value records
simoncozens c73de1a
Variable scalar tests
simoncozens 0c13412
Support variable scalars in pos A V (...);
simoncozens a32d7ae
Format bug
simoncozens be66887
Useful property
simoncozens 803dc38
Add support for the conditionset statement
simoncozens 98215d3
Parse variation blocks
simoncozens 46527aa
Round-trip FEA correctly
simoncozens 32ee444
Store the conditional features in a dictionary until we work out what…
simoncozens 0cb89cc
Rearrange featureVars so we can do *really* raw feature builds (by lo…
simoncozens 699ffe0
Oops, leftover when testing something else
simoncozens 087848d
A more generic interface, taking either GSUB or GPOS table
simoncozens 0de9ce6
Normalize condition sets when storing them
simoncozens 0031326
feature_variations_ is a better name than conditionalFeatures_
simoncozens c87399b
Support building feature variations using the "condition" statement.
simoncozens 389b0ea
Put count fields in ttx
simoncozens 6937cc3
Set count fields when building feature variations
simoncozens bd8ba64
Allow float values in condition sets.
simoncozens ddc7658
Correct indentation
simoncozens 8f06c0e
Address feedback
simoncozens eab87ed
Run black on all touched files
simoncozens File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not immediately clear what's going on here, why is the
features_
attributes temporarily swapped with an empty dict. Maybe add a comment