Support new AFDKO variable layout syntax #2228

…ase"

Previously otlLib was generating None if the values themselves were empty even if the value format was non-empty. This happened to work for compiling to binary since the compiler handles Value=None. But this was confusing varLib.merger module (as in when building variable fonts from such otlLib-built master GSUB/GPOS tables, without roundtripping to OTF/TTF binary first), because in varLib.merger, a None means "this master doesn't provide that info; skip it"; whereas in a PairPos table a None as generated by otlLib simply meant "all values are zero", which is different from "this master doesn't provide this value". This fixes that, such that ufo2ft can build variable-font without saving masters to binary. Part of googlefonts/ufo2ft#486

…ubst The format values for those are automatically handled in postRead/preWrite to choose optimal format. As such, don't write them in XML. Reduces noise. fonttools#2236 (comment)

This reverts commit fb0c60c.

fonttools#2238 (comment)

Fixes the one failing test after previous commit.

I'm the only one who was using it. Remove now that pytest is what we call.

Like when decompiled. See fonttools@2089d05#r48578120 Part of fonttools#2237

Like when they are decompiled. Part of fonttools#2237

fonttools#2232

* Replaced all from ...py23 import * with explicit name imports, or removed completely when possible. * Replaced tounicode() with tostr() * Changed all BytesIO ans StringIO imports to from io import ..., replaced all UnicodeIO with StringIO. * Replaced all unichr() with chr() * Misc minor tweaks and fixes

This does two things: 1. Intersect subsetter glyphset with the table's Coverage before passing to ClassDef1 for subsetting. Anything that doesn't get past Coverage wouldn't ever get to ClassDef1, 2. Never reuse class0 of ClassDef2. There's unspoken assumption that ClassDef2's class0 is never used for actual kerning, since that's the unbounded "every other glyph" class. Previously our ClassDef subsetter was reusing class0 if "every other glyph" happened to become empty because of the subset glyphset. Don't do that for PairPos's ClassDef2. As a result of this assumption, don't keep a PairPosClass2 subtable if only ClassDef2's class0 survived subsetting. Would be good to add tests for both. Related to harfbuzz/harfbuzz#2703

… succeeded. This fixes fonttools#536

…eption handler; factor reading table from file into separate function

FIxes fonttools#2257

Like the recent change to __isub__/__iadd__(). This, as well as the other, change do not handle overflows. Going to fix that now.

The memory increase is negligible, but means that we don't have to worry about integer overflows anymore.

We do proper rounding these days, so revert this back. fonttools#964 (comment)

Such a pain that this is a speedup...

Using .frombytes() since bytes() constructor can make zeros fast.

Always store coordinates as float. Convert to int in __getitem__() if is whole. This changes observed values. But we never made any guarantees so that's fine.

If compatibility is an issue, we should rewrite it in terms of "bin(flag)".

The latter is more expensive in GlyphCoordinates().

Fixes tests after 7adbe44

Remove tests that passed float in.

We verify the code instead.

Based on subsequent review feedback.

Pass them down to tv.compile(). Tests need to be updated for changed new internal tv.compile() API.

Special-case "all points used" representation in the internal API.

fonttools#2261 (comment)

…ints"

Related: fonttools#2263 Part of: fonttools#2261

I suggested Cosimo add that code in fonttools#1528 Upon further inspection now, that code is unnecessary and even wrong in cases where different masters have different ascent, because that would result in encoding variations for vertical phantom points, which will be then either be unused or double-apply on top of ascent etc.

To reduce calling TTFont.__getitem__ many times per glyph!

…ot found And use it in a couple places.

Also simplify bounds check.

…ints Will add old name with old API next.

…oints fonttools#2266

Co-authored-by: Nikolaus Waxweiler <madigens@gmail.com>

This ignores 0/None values that don't need to be encoded.

Fixes fonttools#2272

…okups fonttools#2276

Fixes fonttools#2276

updated to indicate that Level 3 sub-space ranges are supported, but you must include the default axis value in the new range

Otherwise head table compilation would fail because of the floating point side bearing. The advance width is already rounded.

Fixes googlefonts/fontmake#766

* default value for varIdx should be 0xFFFFFFFF to indicate 'no variations' * use lc hex notation as per feedback

…contextual positioning with "value at end" (fonttools#2294) * add test that fails for fonttools#2293 * fixing fonttools#2293: rewrite of contextual positioning logic, ensure len(suffix) > 1 yields the correct result; checking more edge cases and raising errors inspired by makeotf * test error cases * only check when we actually have a value * catch one more case that makeotf errors on and we didn't

Was not noticed because it was for the most part unused.

Huh. Somehow the writeArray() was never wired up. We lose the failing array index in the exception, but is fine to me.

…bles

Part of fonttools#2279

The full optimizer in varLib.varStore still needs to be updated. But this pretty much enables building 32bit VarStores, even if they won't be fully optimal. Part of fonttools#2279

This concludes fonttools#2279 Part of fonttools#2285

…sts (which are therefore commented out)

…t 100% sure this is correct for all platforms.

fonttools@db6171d#r628543432

fonttools#2285 (comment)

translate leading backslashes of UNC path to forward slashes.

Sometimes skia-pathops simplify may fail (for unknown reasons which I'm still trying to debug). It's a good idea to know the name of the offending glyph google/fonts#3365

…ia bug Fixes google/fonts#3365 See https://bugs.chromium.org/p/skia/issues/detail?id=11958 for details

fonttools#2288 (comment)

Fixes fonttools#2295

sub [a b c] by NULL; was producing errors, now it builds as multiple statements.

a lot of places instead pass in the 'self' parameter, incorrectly assuming that is a Merger. This is meant to fix 'AttributeError: 'dict' object has no attribute 'ttfs'' as reported in googlefonts/fontmake#766 (comment)

This currently throws a KeyError: ('uniE004', 'BaseGlyphRecordArray')

…in populateCOLRv0 Same when LayerV1List is empty. All these fields are optional in v1

…etting COLRv1 table Thanks Qunxin for reporting the bug!

* Add TTGlyphPointPen * Format code with black * Implement TTGlyphPen and TTGlyphPointPen with common base class * Use PenError instead of assert * Add note about decomposing mixed composites to the docstring

Fixes fonttools#2312

the useless subtable might have been there to stop the next subtable from applying... fonttools#2313 (comment)

It is an optional dictionary. Even the ttGlypgPen_test.py or the fontBuilder.py calls TTGlyphPen(None) often. We caught this because internally we run a type-checker. Originally the glyphSet parameter was not explicitly typed. Now that it is, make the type hints match the way code is intended to be used.

to reduce the bus factor -- or maybe I should call it the 'new baby factor'

nice that twine catches issues with RST as well

…hods Fixes fonttools#2319

See adobe-type-tools/afdko#153 (comment)

… to do with them

…okup ID) See fonttools#2316

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support new AFDKO variable layout syntax #2228

Support new AFDKO variable layout syntax #2228

Commits on Oct 22, 2021