Set count fields when building feature variations

fonttools · Oct 22, 2021 · 4cab82e · 4cab82e
1 parent 974ebd2
commit 4cab82e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/Lib/fontTools/varLib/featureVars.py b/Lib/fontTools/varLib/featureVars.py
@@ -424,6 +424,7 @@ def buildFeatureVariations(featureVariationRecords):
     fv = ot.FeatureVariations()
     fv.Version = 0x00010000
     fv.FeatureVariationRecord = featureVariationRecords
+    fv.FeatureVariationCount = len(featureVariationRecords)
     return fv
 
 
@@ -442,9 +443,11 @@ def buildFeatureVariationRecord(conditionTable, substitutionRecords):
     fvr = ot.FeatureVariationRecord()
     fvr.ConditionSet = ot.ConditionSet()
     fvr.ConditionSet.ConditionTable = conditionTable
+    fvr.ConditionSet.ConditionCount = len(conditionTable)
     fvr.FeatureTableSubstitution = ot.FeatureTableSubstitution()
     fvr.FeatureTableSubstitution.Version = 0x00010000
     fvr.FeatureTableSubstitution.SubstitutionRecord = substitutionRecords
+    fvr.FeatureTableSubstitution.SubstitutionCount = len(substitutionRecords)
     return fvr
 
 
@@ -454,6 +457,7 @@ def buildFeatureTableSubstitutionRecord(featureIndex, lookupListIndices):
     ftsr.FeatureIndex = featureIndex
     ftsr.Feature = ot.Feature()
     ftsr.Feature.LookupListIndex = lookupListIndices
+    ftsr.Feature.LookupCount = len(lookupListIndices)
     return ftsr
 
 

diff --git a/Tests/feaLib/data/variable_conditionset.ttx b/Tests/feaLib/data/variable_conditionset.ttx
@@ -51,6 +51,7 @@
         </ConditionSet>
         <FeatureTableSubstitution>
           <Version value="0x00010000"/>
+          <!-- SubstitutionCount=1 -->
           <SubstitutionRecord index="0">
             <FeatureIndex value="0"/>
             <Feature>