Report overrides

[simoncozens]

Description

This fixes #4428.

Checklist

• update CHANGELOG.md
• wait for the tests to pass
• request a review

[simoncozens]

I have no idea what Windows is sad about.

[felipesanches]

it seems to be a codepage 1252 encoding problem

[felipesanches]

apparently related to the rich module formatting the messages

[felipesanches]

[felipesanches]

I don't see this "\u258c" char in the source code. Unicode char U+258C is a LEFT HALF BLOCK symbol. I would think it could be used by rich when drawing borders of tables. But this is not used on these override messages.

Maybe we still have multi-threading bugs here causing corrupted characters to reach the terminal reporter output?

[simoncozens]

I got it. It's the Markdown block quote (>) used to format the override "reason".

https://github.com/Textualize/rich/blob/26152e9cc95eef9c8f363d7bf1dfda426275348d/rich/markdown.py#L215-L217

[felipesanches]

Great! Let's not use it for now, then. And we may report a bug on rich project so we may use it in the future once they address the bug on a future release.

[simoncozens]

Yep, done all that. I removed the use of blockquotes, and filed Textualize/rich#3281.