Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): empty css cache response generates invalid font-face #934

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

ayuhito
Copy link
Member

@ayuhito ayuhito commented Feb 8, 2024

When converting an undefined variable to string later in the @font-face generate, it actually converts it to "undefined" as a string which mangles the CSS into something like undefined@font-face {...}. This broke loading fonts in some areas of the website.

Also a tiny styling fix to the variable filters checkbox that broke the flex gap between the checkbox and text.

Copy link

changeset-bot bot commented Feb 8, 2024

⚠️ No Changeset found

Latest commit: 1c9a30c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Feb 8, 2024

Deployed to staging: https://staging.fontsource.org/

@ayuhito ayuhito merged commit 60ee16b into main Feb 11, 2024
1 check passed
@ayuhito ayuhito deleted the fix/undefined-font-face branch February 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant