Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): multi word subset #920

Merged
merged 3 commits into from
Dec 15, 2023
Merged

fix(api): multi word subset #920

merged 3 commits into from
Dec 15, 2023

Conversation

ayuhito
Copy link
Member

@ayuhito ayuhito commented Dec 15, 2023

Some subsets may have multiple words, e.g. caucasian-albanian, which would incorrectly be cutoff with the previous logic when creating download manifests.

Copy link

changeset-bot bot commented Dec 15, 2023

🦋 Changeset detected

Latest commit: a186246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
download Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ayuhito ayuhito merged commit 9b32c26 into main Dec 15, 2023
4 checks passed
@ayuhito ayuhito deleted the fix/multi-subset branch December 15, 2023 22:33
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
@ayuhito
Copy link
Member Author

ayuhito commented Dec 15, 2023

This may be the real fix for #916 in retrospect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant