fix(cli): rework font downloading #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7d203d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Okay, I completely forgot about the tests, give me some more time :D |
|
Thanks for making this PR! 🎉 I'll wait to review after the tests are written so I have a better idea of what the expected outputs are. 👍
Google changes things a lot which includes removing things so this should be a non-issue. See related: #578 |
Fixes the bug that caused the non-variable Google fonts to be downloaded twice, to the same target file, causing indeterministic file changes and slightly broken font files. See fontsource#712 for more context. Fixes fontsource#712.
|
Should I also add a changeset? If yes, is this a patch level change? |
ayuhito
reviewed
May 27, 2023
ayuhito
approved these changes
May 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug that caused the non-variable Google fonts to be downloaded twice, to the same target file, causing indeterministic file changes and slightly broken font files. See #712 for more context.
Fixes #712.
I ran my WOFF size checking script on the output of this PR, and all the previous errors are gone (except manual fonts), so it seems to work.
There are some unexpected changes relative to font-files@6332265:
Some fonts are completely missing, but they also don't show up on the Google Fonts website for me:
A subset is missing from one font, but again, it doesn't show up in the raw metadata for me either: