Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more weights to Roboto Flex #670

Open
maggiedbaker opened this issue May 16, 2023 · 5 comments
Open

Add more weights to Roboto Flex #670

maggiedbaker opened this issue May 16, 2023 · 5 comments
Labels
bug Something isn't working upstream

Comments

@maggiedbaker
Copy link

Describe the feature you'd like to request

Roboto Flex only supports the 400 font-weight via FontSource, but its Google Fonts page shows that it has many different weights:

https://github.com/fontsource/fontsource/tree/main/fonts/google/roboto-flex

https://fonts.google.com/specimen/Roboto+Flex

Describe the solution you'd like

Add the font weights, ranging from 100 to 1000, to FontSource's Roboto Flex package.

Thank you!!

Describe alternatives you've considered

No response

Additional context

No response

@ayuhito
Copy link
Member

ayuhito commented May 19, 2023

This seems to be an odd bug since those static files you're looking for don't seem to exist upstream either. I would suggest using Roboto if you're only looking for the individual weights since they are identical otherwise.

@ayuhito ayuhito added bug Something isn't working upstream and removed enhancement New feature or request labels May 20, 2023
@fitojb
Copy link

fitojb commented May 22, 2023

Claiming that Roboto and Roboto Flex are identical is just not true. All glyphs have been redrawn by David Berlow and others. And individual static weights can be made from the variable font by using tools like Slice.

@ayuhito
Copy link
Member

ayuhito commented May 22, 2023

Claiming that Roboto and Roboto Flex are identical is just not true. All glyphs have been redrawn by David Berlow and others. And individual static weights can be made from the variable font by using tools like Slice.

Apologies. I was not aware of the visual differences from a quick glance assuming there was a static variant of Roboto Flex.

That said, for the purposes of this issue, we can't manually monkey-patch upstream Google Fonts in this repository. We mirror their API so we have to rely on them to resolve this issue.

@daniel-j-h
Copy link

Hey I came across this and was wondering if it's still an issue.

When I import the default as in

import "@fontsource-variable/roboto-flex";

it looks like we do get the weight axis and we can change weight freely.

rf-default

And if we import the full variable font we get all axis

import "@fontsource-variable/roboto-flex/full.css";

rf-full

I followed the documentation there is by now on variable fonts here

Therefore I wanted to ask if this is still an issue since I can use the weight axis freely 🤗

Roboto Flex only supports the 400 font-weight via FontSource, but its Google Fonts page shows that it has many different weights:

@ayuhito
Copy link
Member

ayuhito commented Oct 15, 2023

@daniel-j-h, the variable files are totally fine. The issue lies in the static files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working upstream
Projects
None yet
Development

No branches or pull requests

4 participants