Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Google Font deprecations gracefully #578

Open
indivisualvj opened this issue Sep 29, 2022 · 3 comments
Open

Handle Google Font deprecations gracefully #578

indivisualvj opened this issue Sep 29, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@indivisualvj
Copy link

Describe the bug
Missing files folder after NPM install and also no files folder in the repo

To Reproduce
Steps to reproduce the behavior:

  1. See other repo font directories
  2. or install via npm and take a look into node_modules/@fontsource/andada

Expected behavior
Install the actual fonts!

@indivisualvj indivisualvj added the bug Something isn't working label Sep 29, 2022
@ayuhito
Copy link
Member

ayuhito commented Sep 29, 2022

This is interesting.

Andada is deprecated so we can't track it on Google APIs anymore.

But we don't store the font files in the repository anymore for Git size reasons.

I think we need to setup a system to detect when Google deprecates a font and handle it to preserve the font files for future Fontsource updates, because this will continue on with new fonts that get deprecated. We'll have to figure that out sometime soon.

For now, you can use version 4.5.0 which has the font files or use its successor Andada Pro as a replacement.

@indivisualvj
Copy link
Author

Thank you!

@ayuhito
Copy link
Member

ayuhito commented Sep 29, 2022

I'd like to keep this open as it is still a valid bug that needs to be fixed eventually :)

@ayuhito ayuhito reopened this Sep 29, 2022
@ayuhito ayuhito changed the title Missing directory/actual files fonts/google/andada/files/* Handle Google Font deprecations gracefully Oct 22, 2022
This was referenced Feb 26, 2023
@ayuhito ayuhito changed the title Handle Google Font deprecations gracefully Missing @fontsource/andada May 21, 2023
@ayuhito ayuhito changed the title Missing @fontsource/andada Handle Google Font deprecations gracefully May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants