Skip to content

Commit

Permalink
drop Node 12 support
Browse files Browse the repository at this point in the history
  • Loading branch information
mvorisek committed Dec 4, 2022
1 parent 988db67 commit c2a37ce
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [12, 14, 16, 18]
node-version: [14, 16, 18]
steps:
- uses: actions/checkout@v3
- name: Setup Node.js ${{ matrix.node-version }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
ref: develop
- uses: actions/setup-node@v3
with:
node-version: 16
registry-url: https://registry.npmjs.org/
- name: pre-setup
run: sh ./scripts/preinstall.sh
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
ref: master
- uses: actions/setup-node@v3
with:
node-version: 14
registry-url: https://registry.npmjs.org/
- name: pre-setup
run: sh ./scripts/preinstall.sh
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"semver": "^7.3.5"
},
"engines": {
"node": ">=12",
"node": ">=14",
"npm": ">=6.14.8"
},
"title": "Fomantic UI",
Expand Down
15 changes: 6 additions & 9 deletions tasks/config/tasks.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,9 @@ let overrideBrowserslist = hasBrowserslistConfig ? undefined : [
'android 4',
];

// Node 12 does not support ??, so a little polyfill
let nullish = (value, fallback) => (value !== undefined && value !== null ? value : fallback);

module.exports = {

banner: nullish(config.banner, release.banner),
banner: config.banner ?? release.banner,

log: {
created: function (file) {
Expand Down Expand Up @@ -95,11 +92,11 @@ module.exports = {

/* Comment Banners */
header: {
year: nullish(config.header.year, (new Date()).getFullYear()),
title: nullish(config.header.title, release.title),
version: nullish(config.header.version, release.version),
repository: nullish(config.header.repository, release.repository),
url: nullish(config.header.url, release.url),
year: config.header.year ?? (new Date()).getFullYear(),
title: config.header.title ?? release.title,
version: config.header.version ?? release.version,
repository: config.header.repository ?? release.repository,
url: config.header.url ?? release.url,
},

plumber: {
Expand Down

0 comments on commit c2a37ce

Please sign in to comment.