New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bracketed hostnames #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note to self: need to remove all |
RubenVerborgh
force-pushed
the
fix/235
branch
from
December 30, 2023 14:42
f30a42a
to
b4507d9
Compare
RubenVerborgh
force-pushed
the
fix/235
branch
4 times, most recently
from
December 30, 2023 14:58
d893964
to
7712ae6
Compare
RubenVerborgh
force-pushed
the
fix/235
branch
from
December 30, 2023 17:01
7712ae6
to
e0906af
Compare
RubenVerborgh
force-pushed
the
fix/235
branch
from
December 30, 2023 17:22
e0906af
to
7a6567e
Compare
Hi @RubenVerborgh, I have a small fix for the changes in 05629af from this PR in #241. |
This was referenced Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #235