Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Acroforms - setting an option to false will still apply the flag #1496

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Fix Acroforms - setting an option to false will still apply the flag #1496

merged 4 commits into from
Feb 7, 2024

Commits on Feb 4, 2024

  1. Add an option check to acroform mixin _resolveFlags(). 

    This resolves foliojs#1495.
    @RicoBrase
    RicoBrase committed Feb 4, 2024
    Configuration menu
    Copy the full SHA
    b5fdeda View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Reworked fix to remove flags from options, if they are falsey.

    @RicoBrase
    RicoBrase committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    aca8ca8 View commit details
    Browse the repository at this point in the history

  2. Added unit test for ignoring false flags in acroforms

    @RicoBrase
    RicoBrase committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    1362c15 View commit details
    Browse the repository at this point in the history

  3. Added entry for removing false flags in changelog.

    @RicoBrase
    RicoBrase committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    8d892b5 View commit details
    Browse the repository at this point in the history