Refactor on equality check function (#1280)

Avoidable 'if' statement
foliojs · Jul 13, 2021 · a41f338 · a41f338
1 parent b5b0ac1
commit a41f338
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/lib/mixins/attachments.js b/lib/mixins/attachments.js
@@ -105,14 +105,11 @@ export default {
 
 /** check two embedded file metadata objects for equality */
 function isEqual(a, b) {
-  if (
-    a.Subtype !== b.Subtype ||
-    a.Params.CheckSum.toString() !== b.Params.CheckSum.toString() ||
-    a.Params.Size !== b.Params.Size ||
-    a.Params.CreationDate !== b.Params.CreationDate ||
-    a.Params.ModDate !== b.Params.ModDate
-  ) {
-    return false;
-  }
-  return true;
+  return (
+    a.Subtype === b.Subtype &&
+    a.Params.CheckSum.toString() === b.Params.CheckSum.toString() &&
+    a.Params.Size === b.Params.Size &&
+    a.Params.CreationDate === b.Params.CreationDate &&
+    a.Params.ModDate === b.Params.ModDate
+  );
 }