Skip to content

Commit

Permalink
UIDATIMP-690 prevent ESLint from dying
Browse files Browse the repository at this point in the history
Due to a [bug in
jsx-exlint](jsx-eslint/jsx-ast-utils#103), the
changed line causes ESLint to die. The bug [has been fixed](jsx-eslint/jsx-ast-utils#102) but hasn't made it's way into a release yet, and it would be really nice to have lint working again!

Refs UIDATIMP-690
  • Loading branch information
zburke committed Oct 11, 2020
1 parent 2a9bae0 commit df139c4
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -66,6 +66,8 @@
* Fix `SyntaxError: Unexpected token 'export'` error when running tests (UIDATIMP-667)
* Fix "Position" in MCL View is not left justified (UIDATIMP-657)
* An error message appears when linking a match profile with Existing record field = "Identifier: ..." to a job profile (UIDATIMP-687)
* Only import MatchingFieldsManager once (UIDATIMP-689)
* Tweak syntax that caused ESLint to die early, allowing it complete, and find bugs like UIDATIMP-689 (UIDATIMP-690)

## [2.1.4](https://github.com/folio-org/ui-data-import/tree/v2.1.4) (2020-08-13)

Expand Down
Expand Up @@ -56,8 +56,9 @@ export const LoanAndAvailability = ({
const currentValue = circulationNotes[index]?.fields.find(item => item.name === 'noteType').value;
const isDirty = currentValue !== initialValue;

const updatedValue = circulationNotesList.find(item => `"${item.value}"` === currentValue)?.label;
const value = updatedValue ? `"${updatedValue}"` : currentValue;
const updatedValue = circulationNotesList.find(item => `"${item.value}"` === currentValue);
const updatedValueLabel = updatedValue?.label;
const value = updatedValueLabel ? `"${updatedValueLabel}"` : currentValue;

return {
value,
Expand Down

0 comments on commit df139c4

Please sign in to comment.