Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FOLIO-3610 pin @babel/generator to 7.19.3 #2175

Closed
wants to merge 3 commits into from
Closed

Conversation

zburke
Copy link
Member

@zburke zburke commented Oct 10, 2022

This is a bit of a shot in the dark to resolve build failures in CI like the following:
Pin @babel/generator to 7.19.3 to deal with an NPE regression in 7.19.4.

[1m�[31mERROR�[39m�[22m in �[1m./node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js�[39m�[22m
�[1mModule build �[1m�[31mfailed�[39m�[22m�[1m (from ./node_modules/babel-loader/lib/index.js):
TypeError: /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js: Cannot read property 'start' of undefined
    at Generator._printComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:667:48)
    at Generator._printLeadingComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:530:10)
    at Generator.print (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:403:10)
    at Generator.printJoin (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:479:12)
    at Generator.printList (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:554:17)
    at Generator.CallExpression (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/generators/expressions.js:216:8)

See https://stackoverflow.com/questions/52087421/module-build-failed-from-node-modules-babel-loader-lib-index-js-typeerror

Refs FOLIO-3610

This is a bit of a shot in the dark to resolve build failures in CI like
the following:
```
[1m�[31mERROR�[39m�[22m in �[1m./node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js�[39m�[22m
�[1mModule build �[1m�[31mfailed�[39m�[22m�[1m (from ./node_modules/babel-loader/lib/index.js):
TypeError: /home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@folio/finance/src/common/utils/validateDuplicateFieldValue.js: Cannot read property 'start' of undefined
    at Generator._printComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:667:48)
    at Generator._printLeadingComments (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:530:10)
    at Generator.print (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:403:10)
    at Generator.printJoin (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:479:12)
    at Generator.printList (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/printer.js:554:17)
    at Generator.CallExpression (/home/jenkins/workspace/Automation/build-platform-complete-snapshot/node_modules/@babel/generator/lib/generators/expressions.js:216:8)
```

See https://stackoverflow.com/questions/52087421/module-build-failed-from-node-modules-babel-loader-lib-index-js-typeerror

Refs FOLIO-3610
Lock to `@babel/generator` `7.19.3`, avoiding the recent `.4` release.

h/t @BogdanDenis for pointing out this release.
@zburke zburke changed the title FOLIO-3610 provide @babel/core, @babel/preset-env dev-deps FOLIO-3610 pin @babel/generator to 7.19.3 Oct 10, 2022
@zburke
Copy link
Member Author

zburke commented Oct 10, 2022

This has been fixed up stream in https://github.com/babel/babel/releases/tag/v7.19.5. It's tempting to stash a ^7.19.5 resolutions entry in here anyway to make sure the buggy .4 release never gets pulled in. But I think that's worse and it's easy to imagine forgetting about this a year from now when we try to upgrade @babel/core to v8 and scratching our heads over where @babel/generator v7 is coming from.

@zburke zburke closed this Oct 10, 2022
@zburke zburke deleted the FOLIO-3610 branch October 10, 2022 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants