-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for React 16 #16
Conversation
Closes #15 |
"react": "^15.5.0", | ||
"react-dom": "^15.5.0" | ||
"react": "^16.0.0", | ||
"react-dom": "^16.0.0" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add react and react-dom peerDependencies of 0.14.x || ^15.0.0 || ^16.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shiawuen and @emilyrohrbough!
One question to sort out, then we can merge and release.
@@ -68,6 +68,9 @@ | |||
] | |||
}, | |||
"jest": { | |||
"setupFiles": [ | |||
"<rootDir>/test/__mocks__/requestAnimationFrame.js" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shiawuen Why was it necessary to add this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
React also depends on requestAnimationFrame (even in test environments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, thanks!
Hi submitting this to make it work with React 16