Update golang.org/x/sys. #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This picks up a new 2022 version of golang.org/x/sys which is caused by golang/go#49219 and is needed to fix building using Go 1.18 on aarch64-darwin.
13 tasks
|
Would it be possible to review and merge if this looks acceptable? Because the dependencies here are vendored, leading to many changes, they are not easy to patch as a package manager. In my case, I'd like to unbreak this package on Darwin for nixpkgs users. /cc @astromechza @harryjsmith @metamemelord @JadeRedworth as the 4 most recent folks who committed to this repository. I envision many of you are quite busy, so I'll only ping occasionally. |
astromechza
approved these changes
Dec 13, 2022
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up a new 2022 version of golang.org/x/sys which is caused by golang/go#49219 and is needed to fix building using Go 1.18 on aarch64-darwin. Fixes #654.
As a side note: We cannot upgrade to the latest version of golang.org/x/sys because, at least for now, it requires a minimum Go version of 1.17.