Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in 3.4.1 #555

Merged
merged 1 commit into from Nov 11, 2019
Merged

Fix regression in 3.4.1 #555

merged 1 commit into from Nov 11, 2019

Conversation

ghiculescu
Copy link

Better handling of keys that are a string in some locales, and a hash in another.

Fixes #553

Better handling of keys that are a string in some locales, and a hash in another.
@coveralls
Copy link

coveralls commented Nov 8, 2019

Pull Request Test Coverage Report for Build 636

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 68.36%

Totals Coverage Status
Change from base Build 634: 0.03%
Covered Lines: 8906
Relevant Lines: 13028

💛 - Coveralls

@TravisBuddy
Copy link

TravisBuddy commented Nov 8, 2019

Hey @ghiculescu,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 72ae75e0-0240-11ea-8e58-e963e1672326

@PikachuEXE PikachuEXE merged commit 92ba756 into fnando:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in 3.4.1 - TypeError: no implicit conversion of String into Hash
4 participants