Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2698. Configure custom comparator defining repeatable migrations order. #2793

Closed
wants to merge 1 commit into from

Conversation

antonbakalets
Copy link

@antonbakalets antonbakalets commented Apr 28, 2020

I would like to control the order of repeatable migrations.
In order to do that I suggest a new configuration parameter repeatableMigrationComparator, fully qualified class name of custom Comparator to determine the order of repeatable migrations.

By default repeatable migrations are ordered by description. Which means as before if not set.

This doesn't brake the main idea that versioned migrations are always applied before repeatable. The custom Comparator implementation controls only repeatable migration order.

I have found that it might close #2698 .

@CLAassistant
Copy link

CLAassistant commented Apr 28, 2020

CLA assistant check
All committers have signed the CLA.

@MikielAgutu
Copy link

Thanks for the contribution. We are planning to do something like this, however the change would be quite a fundamental extension to the way Flyway works. We'd like to solve the problem in a more general way - for instance, to help with versioned migrations too (e.g. interleaving with repeatables).

There's a fair bit we need to consider, so we're holding off until V7 at the earliest. We'll keep this PR open as a reference.

@DoodleBobBuffPants
Copy link
Contributor

Closing as we will be tackling the problem of custom migration ordering differently

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define script execution order
4 participants