New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Housekeeping] Bump Go version to 1.22 #5032
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5032 +/- ##
===========================================
- Coverage 58.98% 34.37% -24.61%
===========================================
Files 645 1131 +486
Lines 55548 118491 +62943
===========================================
+ Hits 32764 40734 +7970
- Misses 20193 74191 +53998
- Partials 2591 3566 +975
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
804d40f
to
23c77cf
Compare
88540c7
to
cc19bab
Compare
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
cc19bab
to
53fec8b
Compare
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
@@ -2,7 +2,7 @@ ARG FLYTECONSOLE_VERSION=latest | |||
FROM ghcr.io/flyteorg/flyteconsole:${FLYTECONSOLE_VERSION} AS flyteconsole | |||
|
|||
|
|||
FROM --platform=${BUILDPLATFORM} golang:1.21.5-bookworm AS flytebuilder | |||
FROM --platform=${BUILDPLATFORM} golang:1.22.1-bookworm AS flytebuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just changed builds so that the Go version will float against the latest z release in #5097 rather than pinning to something like 1.22.1
(to make it easier for now to stay on top of security updates in Go itself). I would suggest we do the same here by using 1.22
for now.
I believe @eapolinario is looking into configuring dependabot to be able to bump this version through a PR.
@lowc1012 , are you still going to work on this PR? If so, can you merge master? |
Tracking issue
Closes #4994
Why are the changes needed?
What changes were proposed in this pull request?
Note:
need to bump
x/tools
in "mockery" (github.com/EngHabu/mockery/cmd/mockery)ref:
vektra/mockery#753
google/wire#401
tested in CI:
https://github.com/lowc1012/flyte/actions/runs/8224113911/job/22487789286
https://github.com/lowc1012/flyte/actions/runs/8224113911/job/22487789227
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link