Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Bump Go version to 1.22 #5032

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lowc1012
Copy link
Contributor

@lowc1012 lowc1012 commented Mar 10, 2024

Tracking issue

Closes #4994

Why are the changes needed?

What changes were proposed in this pull request?

Note:

need to bump x/tools in "mockery" (github.com/EngHabu/mockery/cmd/mockery)

ref:
vektra/mockery#753
google/wire#401

tested in CI:
https://github.com/lowc1012/flyte/actions/runs/8224113911/job/22487789286
https://github.com/lowc1012/flyte/actions/runs/8224113911/job/22487789227

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 10, 2024
Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.37%. Comparing base (a49284e) to head (cc19bab).
Report is 11 commits behind head on master.

❗ Current head cc19bab differs from pull request most recent head 5301cbb. Consider uploading reports for the commit 5301cbb to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5032       +/-   ##
===========================================
- Coverage   58.98%   34.37%   -24.61%     
===========================================
  Files         645     1131      +486     
  Lines       55548   118491    +62943     
===========================================
+ Hits        32764    40734     +7970     
- Misses      20193    74191    +53998     
- Partials     2591     3566      +975     
Flag Coverage Δ
unittests 34.37% <ø> (-24.61%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lowc1012 lowc1012 changed the title [Housekeeping] Bump Go version to 1.22 WIP: [Housekeeping] Bump Go version to 1.22 Mar 10, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 11, 2024
@lowc1012 lowc1012 changed the title WIP: [Housekeeping] Bump Go version to 1.22 [Housekeeping] Bump Go version to 1.22 Mar 11, 2024
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
Signed-off-by: Ryan Lo <wenchih@apache.org>
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Mar 12, 2024
@@ -2,7 +2,7 @@ ARG FLYTECONSOLE_VERSION=latest
FROM ghcr.io/flyteorg/flyteconsole:${FLYTECONSOLE_VERSION} AS flyteconsole


FROM --platform=${BUILDPLATFORM} golang:1.21.5-bookworm AS flytebuilder
FROM --platform=${BUILDPLATFORM} golang:1.22.1-bookworm AS flytebuilder
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just changed builds so that the Go version will float against the latest z release in #5097 rather than pinning to something like 1.22.1 (to make it easier for now to stay on top of security updates in Go itself). I would suggest we do the same here by using 1.22 for now.

I believe @eapolinario is looking into configuring dependabot to be able to bump this version through a PR.

@eapolinario
Copy link
Contributor

@lowc1012 , are you still going to work on this PR? If so, can you merge master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping Issues that help maintain flyte and keep it tech-debt free size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Housekeeping] Move to go 1.22
3 participants