Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix capture_exception signature #65

Merged
merged 1 commit into from Feb 28, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/uniform_notifier/sentry.rb
Expand Up @@ -16,7 +16,7 @@ def _out_of_channel_notify(data)
opt = UniformNotifier.sentry if UniformNotifier.sentry.is_a?(Hash)

exception = Exception.new(message)
Sentry.capture_exception(exception, opt)
Sentry.capture_exception(exception, **opt)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/uniform_notifier/sentry_spec.rb
Expand Up @@ -12,7 +12,7 @@ class Sentry
end

it 'should notify sentry' do
expect(Sentry).to receive(:capture_exception).with(UniformNotifier::Exception.new('notify sentry'), {})
expect(Sentry).to receive(:capture_exception).with(UniformNotifier::Exception.new('notify sentry'))

UniformNotifier.sentry = true
UniformNotifier::SentryNotifier.out_of_channel_notify(title: 'notify sentry')
Expand Down