allow apps to not include the user in a notification #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrobbin
force-pushed
the
skip-user-in-notification-data
branch
from
905352b
to
92f9f3b
Compare
|
@agrobbin I'd like to merge the PR, but it breaks the CI. Please fix it first. |
While some may find the current OS user helpful, in other contexts, that user is randomly assigned and not material to the notification itself. Consider a deployment enviroment like Heroku, which will use a different OS user for each deployable, and each deploy. It may also cause grouping issues in services like Sentry, which use the exception / notification content to determine whether the situation has occurred already. This does not change the default behavior, but rather introduces a new option to skip including that information in notifications, for those who want to.
agrobbin
force-pushed
the
skip-user-in-notification-data
branch
from
92f9f3b
to
feb8ed1
Compare
|
@felixonmars should be fixed now! |
|
Thanks for the quick review and merge @flyerhzm! I really appreciate it. Hopefully this is something that will be helpful for others. I saw you just released a new version a week or so ago, but hopefully this is something that can be released soon. |
|
@agrobbin thank you for your contribution, I'll release it later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While some may find the current OS user helpful, in other contexts, that user is randomly assigned and not material to the notification itself. Consider a deployment enviroment like Heroku, which will use a different OS user for each deployable, and each deploy.
It may also cause grouping issues in services like Sentry, which use the exception / notification content to determine whether the situation has occurred already.
This does not change the default behavior, but rather introduces a new option to skip including that information in notifications, for those who want to.