Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support ActiveRecord 7.1.0 #675

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

hatsu38
Copy link
Contributor

@hatsu38 hatsu38 commented Sep 13, 2023

I always use BULLET.

When rails7.1.0.beta1 was released and I was trying it out, I discovered that it is not supported by this Gem.

I would like to be able to use bullets in 7.1 as well.

@hatsu38 hatsu38 changed the title [WIP]Add Support ActiveRecord 7.1.0.beta1 Add Support ActiveRecord 7.1.0.beta1 Sep 13, 2023
@hatsu38 hatsu38 marked this pull request as ready for review September 13, 2023 04:15
@navidemad
Copy link

Can you try to change it to 7.1.0.rc2 ?

@PikachuEXE
Copy link
Contributor

gem install rails -v '~> 7.1.0.beta1' will make bundler install 7.1.0.rc2 (and 7.1.x if they are released) assuming there is no version lock

@hatsu38
Copy link
Contributor Author

hatsu38 commented Oct 2, 2023

According to this article, Rails 7.1.0 is scheduled to be released on October 5th. I am planning to upgrade the version once it's released.

https://rubyonrails.org/2023/10/1/Rails-Rails-7-1-enters-the-release-candidate-phase

@euglena1215
Copy link

I think it is valuable to merge support up to 7.1.0.rc2 into the main branch early.

If we want to run a Rails application using bullet gem in a Rails 7.1 environment now, we need to remove the bullet gem. (including changes to the initializer).
It is more useful to change the bullet gem designation from the latest version to the main branch.

@joshRpowell
Copy link

rails 7.1 was released https://github.com/rails/rails/releases/tag/v7.1.0

@flyerhzm
Copy link
Owner

flyerhzm commented Oct 5, 2023

@hatsu38 As activerecord 7.1 was released, I'm glad to support it in bullet, please change the dependency to rails 7.1, or I'll do it by myself, thanks.

@hatsu38 hatsu38 changed the title Add Support ActiveRecord 7.1.0.beta1 Add Support ActiveRecord 7.1.0 Oct 5, 2023
@hatsu38
Copy link
Contributor Author

hatsu38 commented Oct 5, 2023

@flyerhzm I updated from 7.1.0.beta1 to 7.1.0.

@cristi
Copy link

cristi commented Oct 5, 2023

looking forward to seeing this released. It prevents people from upgrading rails

Bundler::GemRequireError: There was an error while trying to load the gem 'bullet'.

thanks for the amazing work!

@flyerhzm flyerhzm merged commit dda0c08 into flyerhzm:main Oct 5, 2023
8 of 10 checks passed
@hatsu38 hatsu38 deleted the feature/support-ActiveRecord-7.1.0 branch October 29, 2023 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants