Skip to content

Commit

Permalink
Merge pull request #576 from spdawson/support-rack-files-iterator-res…
Browse files Browse the repository at this point in the history
…ponses

Support Rack::Files::Iterator responses
  • Loading branch information
flyerhzm committed Jun 11, 2021
2 parents 59a5b92 + d0288e6 commit 1d06a92
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
2 changes: 1 addition & 1 deletion lib/bullet/rack.rb
Expand Up @@ -84,7 +84,7 @@ def html_request?(headers, response)
def response_body(response)
if response.respond_to?(:body)
Array === response.body ? response.body.first : response.body
else
elsif response.respond_to?(:first)
response.first
end
end
Expand Down
11 changes: 11 additions & 0 deletions spec/bullet/rack_spec.rb
Expand Up @@ -2,6 +2,8 @@

require 'spec_helper'

require 'rack/files'

module Bullet
describe Rack do
let(:middleware) { Bullet::Rack.new app }
Expand Down Expand Up @@ -261,6 +263,15 @@ module Bullet
expect(middleware.response_body(response)).to eq body_string
end
end

context 'when `response` is a Rack::Files::Iterator' do
let(:response) { instance_double(::Rack::Files::Iterator) }
before { allow(response).to receive(:is_a?).with(::Rack::Files::Iterator) { true } }

it 'should return nil' do
expect(middleware.response_body(response)).to be_nil
end
end
end
end
end

0 comments on commit 1d06a92

Please sign in to comment.