Fix flycheck-error-level-interesting-p #1870
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to its docstring,
flycheck-error-level-interesting-p
should return true if there are no errors as or more severe thanflycheck-navigation-minimum-level
. Currently, however, it only checks if there are any errors exactly as severe asflycheck-navigation-minimum-level
(viaflycheck-has-current-errors-p
). This patch:flycheck-has-current-errors-p
flycheck-has-errors-p
flycheck-has-current-errors-atleast-p
flycheck-has-errors-atleast-p
flycheck-error-level-interesting-p
to useflycheck-has-current-errors-atleast-p
, instead of its "exact" sibling, bringing its actual behavior in line with its documented behaviorI also considered changing
flycheck-has-[current-]errors-p
to use>=
instead ofeq
, but since it has a public name (I'm assuming--
is used to signal that a symbol is private), I didn't want to introduce a backwards-breaking change. If instead it should be the case thatflycheck-has-[current-]errors-p
check for errors at least as severe aslevel
, then I can edit this PR to modify them directly.