Make Haml-Syntax-Checker compatible with haml ~> 5.0.4 #1325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Could that be an upstream bug? |
Yes, i would think so. |
Looks like it has already been reported. Let's wait to see if they intend to fix it before working around it in Flycheck. In any case, thank you for promptly suggesting a patch (including a test, even!). |
TeaMoe
changed the title
TeaMoe
changed the title
|
Hi, I've updated my commit to work with haml v5.0.4, which includes a fix for --stdin. |
fmdkdd
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using HAML from stdin is broken if the file has a ruby syntax error, but no haml error.
And Ruby-Syntax errors are reported in a different format, so i had to extend the error_patterns.