Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure DevOps compatibility issues #104

Closed
stefanprodan opened this issue Aug 13, 2020 · 7 comments · Fixed by #213
Closed

Azure DevOps compatibility issues #104

stefanprodan opened this issue Aug 13, 2020 · 7 comments · Fixed by #213
Labels
area/git Git related issues and pull requests

Comments

@stefanprodan
Copy link
Member

In source-controller we use go-git to perform Git operations.

According to these issues go-git/go-git#64, src-d/go-git#335, src-d/go-git#1058 Azure DevOps doesn't implement Git v1 protocol and go-git doesn't implement v2 that supposed to work with Azure. As shelling out to the git binary is not an option for us, we have to figure out a way to Azure DevOps.

@stefanprodan stefanprodan added the area/git Git related issues and pull requests label Aug 13, 2020
@artbegolli
Copy link

Watching this - curious as to what solution you guys come up with

@dirien
Copy link

dirien commented Sep 10, 2020

Leaving a comment here too. As we are also affected by this.

@stefanprodan : Would it mean, in worst case we need to extend the go-git code for v2 handling?

@stefanprodan
Copy link
Member Author

Would it mean, in worst case we need to extend the go-git code for v2 handling?

Either Azure DevOps implements Git v1 or we need to add support for v2 in go-git.

@vtbassmatt
Copy link

👋 hi, I'm the product manager for Azure Repos server (which is where protocol stuff lives). I'm afraid we have no plans to relax the requirement that clients support multi_ack. It looked from some of the related issues like go-git is not planning to implement multi_ack but is working on a v2 protocol implementation.

@phillebaba
Copy link
Member

If anyone is interested following along the work to get this fixed. go-git/go-git#200

@stefanprodan
Copy link
Member Author

stefanprodan commented Nov 9, 2020

With @vtbassmatt stance and @phillebaba PR getting rejected we are now investigating if it's possible to replace go-git with Go bindings for libgit2. Meanwhile if your are an Azure DevOps user, please consider switching to GitHub.

@dirien
Copy link

dirien commented Nov 9, 2020

@stefanprodan That would be awsome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/git Git related issues and pull requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants