Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Applications] Use git2go instead of go-git for git based helm repo #12630

Open
dharapvj opened this issue Sep 8, 2023 · 0 comments
Open

[Applications] Use git2go instead of go-git for git based helm repo #12630

dharapvj opened this issue Sep 8, 2023 · 0 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dharapvj
Copy link
Contributor

dharapvj commented Sep 8, 2023

Description of the feature you would like to add / User story

Currently, for Applications feature, to pull helm chart from git repo, KKP uses go-git library.

But, using git as source for helm chart does not work with Azure Devops based Git repo since Azure has not implemented "classic" git protocol and has only deployed multi_ack protocol. [Citation for this claim in tickets linked below]

We received errors on ApplicationInstallation like below:

Events:
  Type     Reason                                  Age                   From                             Message
  ----     ------                                  ----                  ----                             -------
  Warning  ApplicationInstallationReconcileFailed  73s (x17 over 6m52s)  kkp-app-installation-controller  handling installation of application installation: failed to download application source: failed to clone repository: empty git-upload-pack given

So until go-git library resolves issues to use it with Azure DevOps, Applications using helm charts from Azure-Devops git repo is not possible. Azure-Devops support for enterprise customers is important.

Flux team has had a temporary fork for go-git which allowed azure devops to work but the fork is now archived so we are not sure if this a right solution. Eventually, flux team went to use git2go library instead of go-git..

Considering that go-git issues are almost 4 years old - it is unlikely to get fixed anytime soon so we should consider migrating to git2go library for clone git (which also supports Azure DevOps)

@dharapvj dharapvj added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

1 participant