Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package_info_plus): adds value equality for PackageInfo #1328

Merged
merged 1 commit into from Nov 9, 2022

Conversation

dkbast
Copy link
Contributor

@dkbast dkbast commented Nov 9, 2022

Description

Overwrites for hashCode and equals for PackageInfo to get value equality, also adds verbose toString method to PackageInfo and adds tests for the changes

Related Issues

Checklist

  • [x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x ] I titled the PR using Conventional Commits.
  • [x ] I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • [x ] All existing and new tests are passing.
  • [x ] The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • [x ] No, this is not a breaking change.

overwrites for hashCode and equals for PackageInfo to get value equality
adds verbose toString method to PackageInfo
adds tests for the changes
Copy link
Member

@nohli nohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Had to restart some tests, now they're passing.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding tests as well!

@miquelbeltran miquelbeltran merged commit d572feb into fluttercommunity:main Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PackageInfo does not overwrite Hashcode and equals
3 participants