Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(package_info_plus)!: two-package federated architecture #1236

Merged
merged 4 commits into from Oct 14, 2022

Conversation

nohli
Copy link
Member

@nohli nohli commented Oct 13, 2022

Description

Refactor package_info_plus from the federated architecture to a platform interface and a package with all platform implementations.

Related Issues

#1226

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

@nohli
Copy link
Member Author

nohli commented Oct 13, 2022

Probably web tests requiring dart:html must be started with flutter test --platform chrome or this?
@miquelbeltran @vbuberen any idea?

@miquelbeltran
Copy link
Member

Web tests were not running before either, so we can remove them, skip them, or renaming the file.

Integration tests for chrome are not enabled on the repo yet.

@miquelbeltran miquelbeltran added Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted labels Oct 14, 2022
@miquelbeltran
Copy link
Member

This seems to be good to merge, no?

@nohli
Copy link
Member Author

nohli commented Oct 14, 2022

Added _disabled at the end of the web test, which I don't find optimal, but it works now.

Why didn't these tests ran before (and without an error), as you mentioned?

@nohli nohli marked this pull request as ready for review October 14, 2022 14:12
@nohli nohli requested a review from vbuberen October 14, 2022 14:12
@miquelbeltran
Copy link
Member

Added _disabled at the end of the web test, which I don't find optimal, but it works now.

Why didn't these tests ran before (and without an error), as you mentioned?

they were sitting in the web package and there was no CI job running them. I have no idea if they work or not 😬

@nohli nohli merged commit eccdc58 into main Oct 14, 2022
@nohli nohli deleted the unfederate-package-info-plus branch October 14, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hacktoberfest Issues taking part in Hacktoberfest hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants