Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missied sizes for iOS #298

Merged
merged 3 commits into from Jul 26, 2022
Merged

Added missied sizes for iOS #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ed1642
Update ios.dart
bossly Nov 5, 2021
1551a8a
added missied sizes for iOS
bossly Nov 5, 2021
e9d1417
fix tests
bossly Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
42 changes: 42 additions & 0 deletions lib/ios.dart
View file
Open in desktop
Expand Up @@ -22,8 +22,14 @@ List<IosIconTemplate> iosIcons = <IosIconTemplate>[
IosIconTemplate(name: '-40x40@1x', size: 40),
IosIconTemplate(name: '-40x40@2x', size: 80),
IosIconTemplate(name: '-40x40@3x', size: 120),
IosIconTemplate(name: '-50x50@1x', size: 50),
IosIconTemplate(name: '-50x50@2x', size: 100),
IosIconTemplate(name: '-57x57@1x', size: 57),
IosIconTemplate(name: '-57x57@2x', size: 114),
IosIconTemplate(name: '-60x60@2x', size: 120),
IosIconTemplate(name: '-60x60@3x', size: 180),
IosIconTemplate(name: '-72x72@1x', size: 72),
IosIconTemplate(name: '-72x72@2x', size: 144),
IosIconTemplate(name: '-76x76@1x', size: 76),
IosIconTemplate(name: '-76x76@2x', size: 152),
IosIconTemplate(name: '-83.5x83.5@2x', size: 167),
Expand Down Expand Up @@ -248,6 +254,30 @@ List<Map<String, String>> createImageList(String fileNamePrefix) {
filename: '$fileNamePrefix-40x40@3x.png',
scale: '3x')
.toJson(),
ContentsImageObject(
size: '50x50',
idiom: 'iphone',
filename: '$fileNamePrefix-50x50@1x.png',
scale: '1x')
.toJson(),
ContentsImageObject(
size: '50x50',
idiom: 'iphone',
filename: '$fileNamePrefix-50x50@2x.png',
scale: '2x')
.toJson(),
ContentsImageObject(
size: '57x57',
idiom: 'iphone',
filename: '$fileNamePrefix-57x57@1x.png',
scale: '1x')
.toJson(),
ContentsImageObject(
size: '57x57',
idiom: 'iphone',
filename: '$fileNamePrefix-57x57@3x.png',
scale: '2x')
.toJson(),
ContentsImageObject(
size: '60x60',
idiom: 'iphone',
Expand Down Expand Up @@ -296,6 +326,18 @@ List<Map<String, String>> createImageList(String fileNamePrefix) {
filename: '$fileNamePrefix-40x40@2x.png',
scale: '2x')
.toJson(),
ContentsImageObject(
size: '72x72',
idiom: 'ipad',
filename: '$fileNamePrefix-72x72@1x.png',
scale: '1x')
.toJson(),
ContentsImageObject(
size: '72x72',
idiom: 'ipad',
filename: '$fileNamePrefix-72x72@2x.png',
scale: '2x')
.toJson(),
ContentsImageObject(
size: '76x76',
idiom: 'ipad',
Expand Down
4 changes: 2 additions & 2 deletions test/main_test.dart
View file
Open in desktop
Expand Up @@ -11,7 +11,7 @@ import 'package:test/test.dart';
// Unit tests for main.dart
void main() {
test('iOS icon list is correct size', () {
expect(ios.iosIcons.length, 15);
expect(ios.iosIcons.length, 21);
});

test('Android icon list is correct size', () {
Expand All @@ -21,7 +21,7 @@ void main() {
test(
'iOS image list used to generate Contents.json for icon directory is correct size',
() {
expect(ios.createImageList('blah').length, 19);
expect(ios.createImageList('blah').length, 25);
});

test('pubspec.yaml file exists', () async {
Expand Down