Skip to content

Commit

Permalink
fix the icons 50 and 57 in contents.json
Browse files Browse the repository at this point in the history
the 50x50 icons are actually meant for ipad, but in our ios.dart they are marked as iphone. while the 57x57 should be 1x and 2x, while in our ios.dart we're using 1x and 3x
  • Loading branch information
adnanjpg committed Sep 2, 2022
1 parent 29d9535 commit 43dbe04
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions lib/ios.dart
Expand Up @@ -54,7 +54,8 @@ void createIcons(FlutterLauncherIconsConfig config, String? flavor) {
image.channels = Channels.rgb;
}
if (image.channels == Channels.rgba) {
print('\nWARNING: Icons with alpha channel are not allowed in the Apple App Store.\nSet "remove_alpha_ios: true" to remove it.\n');
print(
'\nWARNING: Icons with alpha channel are not allowed in the Apple App Store.\nSet "remove_alpha_ios: true" to remove it.\n');
}
String iconName;
final dynamic iosConfig = config.ios;
Expand Down Expand Up @@ -262,13 +263,13 @@ List<Map<String, String>> createImageList(String fileNamePrefix) {
.toJson(),
ContentsImageObject(
size: '50x50',
idiom: 'iphone',
idiom: 'ipad',
filename: '$fileNamePrefix-50x50@1x.png',
scale: '1x')
.toJson(),
ContentsImageObject(
size: '50x50',
idiom: 'iphone',
idiom: 'ipad',
filename: '$fileNamePrefix-50x50@2x.png',
scale: '2x')
.toJson(),
Expand All @@ -281,7 +282,7 @@ List<Map<String, String>> createImageList(String fileNamePrefix) {
ContentsImageObject(
size: '57x57',
idiom: 'iphone',
filename: '$fileNamePrefix-57x57@3x.png',
filename: '$fileNamePrefix-57x57@2x.png',
scale: '2x')
.toJson(),
ContentsImageObject(
Expand Down

0 comments on commit 43dbe04

Please sign in to comment.