Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the mode of CircularProgressIndicator to adaptive #682

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danger-ahead
Copy link

fixes #680

@diegotori
Copy link
Collaborator

LGTM. Will have to run your changes locally before I merge.

@danger-ahead
Copy link
Author

LGTM. Will have to run your changes locally before I merge.

Thanks!

@binSaed
Copy link

binSaed commented Nov 5, 2022

LGTM

@danger-ahead
Copy link
Author

@binSaed @diegotori is this PR ready to merge?

@diegotori
Copy link
Collaborator

@binSaed @diegotori is this PR ready to merge?

I'll review it in the next couple of days, or this weekend.

@diegotori
Copy link
Collaborator

@danger-ahead quick question. How does CircularProgressIndicator.adaptive() handle it's color on iOS when uses the Cupertino one?

In other words, documentation might be necessary for CupertinoControls in order to properly theme that value, or at least briefly explain what a user might do to change the indicator color on iOS.

Long story short, that adaptive version ignores valueColor and friends on iOS.

@hamishjohnson
Copy link

@danger-ahead quick question. How does CircularProgressIndicator.adaptive() handle it's color on iOS when uses the Cupertino one?

In other words, documentation might be necessary for CupertinoControls in order to properly theme that value, or at least briefly explain what a user might do to change the indicator color on iOS.

Long story short, that adaptive version ignores valueColor and friends on iOS.

On iOS, there is only one color and you can update it with background color.

CircularProgressIndicator.adaptive(
    backgroundColor: Colors.red,
  ),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change CircularProgressIndicator to be adaptive
4 participants