[camera_avfoundation] Adds Swift Package Manager compatibility #6710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
commented
May 10, 2024
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| @import AVFoundation; | |||
| @import Foundation; | |||
| @import UIKit; | |||
There was a problem hiding this comment.
If I enable Swift Package Manager, I would get build errors like:
Unknown type name 'UIDeviceOrientation'
This change fixed these errors. It's not clear to me what's different between Cocoapods and SPM here.
loic-sharma
commented
May 10, 2024
| @@ -7,7 +7,7 @@ | |||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| /// Queue-specific context data to be associated with the capture session queue. | |||
| extern const char* FLTCaptureSessionQueueSpecific; | |||
| extern const char *FLTCaptureSessionQueueSpecific; | |||
There was a problem hiding this comment.
This was updated by clang-format
|
I'll open a new pull request that uses the new pattern described in flutter/flutter#148572 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of what this PR is changing or adding, and why. Consider including before/after screenshots.
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.