-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart #6670
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update version and change log so that this can be published to pub dev?
84868a0
to
0505d5c
Compare
@chunhtai done |
i am using gorouter with bottomnavigation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you rebase again? this package has a lot of traffic
@chunhtai rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi, can you rebase again and you also update the version number in pubspec.yaml |
…for push_with_shell_route.dart
…h fix for URL in `navigation.md`
@hangyujin @chunhtai done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…for push_with_shell_route.dart (flutter#6670) [go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart
[go_router] docs: updated link in navigation.md to correct file path for push_with_shell_route.dart
Pre-launch Checklist
dart format
.)[shared_preferences]
pubspec.yaml
with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.md
to add a description of the change, following repository CHANGELOG style.///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.