Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[animations] Fixes shadow when Material 3 is enabled. #2502

Closed
wants to merge 4 commits into from
Closed

[animations] Fixes shadow when Material 3 is enabled. #2502

wants to merge 4 commits into from

Conversation

xVemu
Copy link

@xVemu xVemu commented Aug 25, 2022

Fixes shadow of closedBuilder widget in OpenContainer, when useMaterial3 is true in ThemeData.

Fixes flutter/flutter#111347

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@stuartmorgan
Copy link
Contributor

Thanks for the contribution! This is still missing some important elements (PR description, issue link showing exactly what the issue it is fixing is, and tests), so I'm going to mark it as a draft. Once those items are complete, please mark it as ready for review. If you have any questions about any of the items, please let us know!

@stuartmorgan stuartmorgan marked this pull request as draft September 6, 2022 20:25
@xVemu xVemu marked this pull request as ready for review September 10, 2022 13:39
@xVemu
Copy link
Author

xVemu commented Sep 12, 2022

Already fixed by flutter/flutter#110624

@xVemu xVemu closed this Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants