New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unpin DDS and roll pub packages #147925
Unpin DDS and roll pub packages #147925
Conversation
DDS was temporarily pinned to 4.1.0 because 4.2.0 triggered some test failures. Those failures should be fixed by vm_service 14.2.2, so this unpins DDS and rolls both of these packages (along with devtools_shared, which is a DDS dependency).
@bkonyi looks like the vm_service changes are failing some tests here:
Example failing test is this one:
I can repro locally, but it's not clear to me if what the test is doing is reasonable or not. It provides an empty stream as the input stream, which causes the method being tested to immediately be terminated as the service is disposed. I feel like it shouldn't be providing a stream that is closed before it has done its testing.. possibly it could close the stream after Thoughts? I can try the above, but want to make sure you don't think vm_service should handle this kind of code. |
Yeah, this is a bad test. We should be using a |
Got it, I'll have a go :) |
@christopherfujino @bkonyi I think this is good now (there's one bot outstanding as I type this, but the rest are green). There are some manual changes besides the pubspec changes to tidy up and fix some tests. You can type ".dart" in the file filter when looking at the changes to easily see the non-pubspec changes. (cc @elliette in case you're interested in when this lands, it includes your permission-to-resume changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DDS was temporarily pinned to 4.1.0 because 4.2.0 triggered some test failures (see #147250). Those failures should be fixed by vm_service 14.2.2, so this unpins DDS and rolls both of these packages (along with devtools_shared, which is a DDS dependency).
(If the bot updates vm_service before this is done, I can rebase over that will reduce the size of this PR to just a few files)