Reland fix memory leaks for tab selector

[ValentinVignal]

Part of #141198

Relands #147403

We need to make sure the bot 'Google testing' passes.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[ValentinVignal]

cc @polina-c

[polina-c]

@chingjun , can you add your review to enable autosubmit to enable google testing?

[chingjun]

RSLGTM to trigger Google Testing

[auto-submit]

auto label is removed for flutter/flutter/147689, due to This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.

• Merge guidelines: A PR needs at least one approved review if the author is already part of flutter-hackers or two member reviews if the author is not a flutter-hacker before re-applying the autosubmit label. Reviewers: If you left a comment approving, please use the "approve" review action instead.

[auto-submit]

auto label is removed for flutter/flutter/147689, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

[polina-c]

Here is the error:

The following assertion was thrown building ...:
		dependOnInheritedWidgetOfExactType<_TabControllerScope>() or dependOnInheritedElement() was called
		before _TabPageSelectorState.initState() completed.
17:32:14.000	U	When an inherited widget changes, for example if the value of Theme.of() changes, its dependent
		widgets are rebuilt. If the dependent widget's reference to the inherited widget is in a constructor
		or an initState() method, then the rebuilt dependent widget will not reflect the changes in the
		inherited widget.
		Typically references to inherited widgets should occur in widget build() methods. Alternatively,
		initialization based on inherited widgets can be placed in the didChangeDependencies method, which
		is called after initState and whenever the dependencies change thereafter.
		The relevant error-causing widget was:
		...
		When the exception was thrown, this was the stack:
		#0      StatefulElement.dependOnInheritedElement.<anonymous closure> (third_party/dart/flutter/lib/src/widgets/framework.dart:5714:9)
		#1      StatefulElement.dependOnInheritedElement (third_party/dart/flutter/lib/src/widgets/framework.dart:5757:6)
		#2      Element.dependOnInheritedWidgetOfExactType (third_party/dart/flutter/lib/src/widgets/framework.dart:4773:14)
		#3      DefaultTabController.maybeOf (third_party/dart/flutter/lib/src/material/tab_controller.dart:409:20)
		#4      _TabPageSelectorState._tabController (third_party/dart/flutter/lib/src/material/tabs.dart:2266:84)
		#5      _TabPageSelectorState._setAnimation (third_party/dart/flutter/lib/src/material/tabs.dart:2315:15)
		#6      _TabPageSelectorState.initState (third_party/dart/flutter/lib/src/material/tabs.dart:2287:5)
		#7      StatefulElement._firstBuild (third_party/dart/flutter/lib/src/widgets/framework.dart:5612:55)
		#8      ComponentElement.mount (third_party/dart/flutter/lib/src/widgets/framework.dart:5457:5)

May be we need to make things resilient to usage after disposal?

[ValentinVignal]

@polina-c I think I just need to not set the animation in the initState but in the didChangeDependencies only. Hopefully fix: Don't use dependOnInheritedWidgetOfExactType in the initState fixes it

[polina-c]

Great!
Can you add test coverage that would catch the issue that you just fixed, in public testing, before internal testing?

[ValentinVignal]

Great! Can you add test coverage that would catch the issue that you just fixed, in public testing, before internal testing?

Sure, the test I added in test: Add a test that uses DefaultTabController fails without my fix in fix: Don't use dependOnInheritedWidgetOfExactType in the initState