include exception details in tool exit displayed when adb call fails

[andrewkolos]

Fixes #125971

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[andrewkolos]

In #125971, @DanTup proposes (as an example) including the stack trace, but I feel like this would be pretty noisy to include in a tool exit message. Perhaps we could include the stack trace in a printTrace call, but I am not sure that would appear in the flutter daemon log output surfaced by VS Code. @DanTup, do you know if printTrace output would appear in these logs (i.e. does Dart-Code invoke flutter daemon with the -v flag)?

[DanTup]

i.e. does Dart-Code invoke flutter daemon with the -v flag?

It doesn't currently. We could change it, but it does mean there would generally be a lot more output (in normal operation when there are no errors) being sent over to the IDEs to be read/ignored.

Is there a way we could include the stack trace info in the call to throwToolExit that could be handled by the daemon mode and always printed? (flutter daemon is only intended for IDEs, so having error messages be verbose even without -v could be helpful).

[andrewkolos]

i.e. does Dart-Code invoke flutter daemon with the -v flag?

It doesn't currently. We could change it, but it does mean there would generally be a lot more output (in normal operation when there are no errors) being sent over to the IDEs to be read/ignored.

Makes sense.

Is there a way we could include the stack trace info in the call to throwToolExit that could be handled by the daemon mode and always printed? (flutter daemon is only intended for IDEs, so having error messages be verbose even without -v could be helpful).

I think we could augment this conditional (excerpted from the code that handles ToolExits)

flutter/packages/flutter_tools/lib/runner.dart

Lines 176 to 178 in be0eb72

	if (verbose) {
	globals.printError('\n$stackTrace\n');
	}

We could change if (verbose) to if (verbose || args.first == 'daemon') (in an actual implementation, I would try avoid the hard-coded dependency on the name of the command, but I'm keeping this simple). I'm pretty neutral on this since it's not clear how often this will be useful, but I'm down to implement this while I'm here. Any disagreement here, @christopherfujino?

[christopherfujino]

LGTM

[andrewkolos]

I'm pretty neutral on this since it's not clear how often this will be useful, but I'm down to implement this while I'm here. Any disagreement here, @christopherfujino?

@christopherfujino 😛

[andrewkolos]

I'm pretty neutral on this since it's not clear how often this will be useful, but I'm down to implement this while I'm here. Any disagreement here, @christopherfujino?

@christopherfujino 😛

I'm also fine to just merge this as-is since this isn't high priority. If you agree, feel free to re-approve