Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve focus example #147464

Merged

Conversation

NobodyForNothing
Copy link
Contributor

Part of #130459. Adds a test to the second focus example and makes the function of the example more clear.

Pre-launch Checklist

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus labels Apr 27, 2024
A111one

This comment was marked as off-topic.

A111one

This comment was marked as off-topic.

@A111one A111one mentioned this pull request Apr 28, 2024
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

Thanks!

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nits 👍

Thanks for helping to test these examples!

examples/api/test/widgets/focus_scope/focus.1_test.dart Outdated Show resolved Hide resolved
examples/api/test/widgets/focus_scope/focus.1_test.dart Outdated Show resolved Hide resolved
@A111one
Copy link

A111one commented Apr 30, 2024 via email

@bleroux bleroux force-pushed the 130459-focus_scope-focus-1_test branch from 7769c6a to 635c69e Compare May 3, 2024 15:22
@NobodyForNothing
Copy link
Contributor Author

Can someone rerun Google testing?

@gspencergoog
Copy link
Contributor

Can someone rerun Google testing?

Done, but it looks like there are merge conflicts anyhow.

@gspencergoog gspencergoog added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024
@auto-submit auto-submit bot merged commit a7bdf36 into flutter:master May 7, 2024
137 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants