Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exceptions when trying to decode state restoration saved datas #147458

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seelrd
Copy link

@seelrd seelrd commented Apr 27, 2024

In packages/flutter/lib/src/services/restoration.dart's _decodeRestorationData function, this function adds a try-catch block to catch any errors happening when calling StandardMessageCodec().decodeMessage(). A FormatException can occur in StandardMessageCodec().decodeMessage() if the data saved for state restoration is corrupted.

This fixes #147456.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Apr 27, 2024
@goderbauer goderbauer self-requested a review April 30, 2024 22:14
@goderbauer
Copy link
Member

Thanks for the contribution. Can you please add a test for this so we don't regress this in the future? Thank you!

Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FormatException: Message corrupted in StandardMessageCodec.readValue during state restoration
2 participants