Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added missing tests for ButtonStyle example #147457

Merged
merged 3 commits into from May 7, 2024
Merged

Added missing tests for ButtonStyle example #147457

merged 3 commits into from May 7, 2024
+74 −1

Conversation

osama383
Copy link
Contributor

Added missing tests for ButtonStyle example. Issue #130459

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 27, 2024
QuncCccccc
QuncCccccc approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution:)

Renzo-Olivares
Renzo-Olivares reviewed May 1, 2024
View reviewed changes
examples/api/test/material/button_style/button_style.0_test.dart Outdated
findsOne,
);

//one OutlinedButton with onPressed null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: end sentence with a period, here and elsewhere. Also capitalize beginning of sentence, here and elsewhere.

Renzo-Olivares
Renzo-Olivares approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@Renzo-Olivares Renzo-Olivares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ small nit.

justinmc
justinmc approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit 👍

examples/api/test/material/button_style/button_style.0_test.dart Outdated
findsOne,
);

//one OutlinedButton with onPressed null
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: These comments should be formatted like this, here and below:

// One OutlinedButton with onPressed null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe just remove them, since the code is self-explanatory.

@bleroux bleroux force-pushed the 130459_add-test-for-button-style-example branch 3 times, most recently from 49799cf to 8b07581 Compare May 6, 2024 11:27
@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 6, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented May 6, 2024

auto label is removed for flutter/flutter/147457, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@bleroux bleroux force-pushed the 130459_add-test-for-button-style-example branch from 73fde6a to c1e73c0 Compare May 7, 2024 07:55
@bleroux bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 7, 2024
@auto-submit auto-submit bot merged commit 774ef8a into flutter:master May 7, 2024
137 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024
@engine-flutter-autoroll
774ef8acf Added missing tests for ButtonStyle example (flutter/flutte…
d309e18 
…r#147457)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 7, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 7, 2024
@engine-flutter-autoroll
774ef8acf Added missing tests for ButtonStyle example (flutter/flutte…
c2addd7 
…r#147457)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 7, 2024
@engine-flutter-autoroll
Roll Flutter from 04424e10fe28 to 7920a52dd568 (27 revisions) (#6683)
55499d8 
flutter/flutter@04424e1...7920a52

2024-05-07 sokolovskyi.konstantin@gmail.com Add tests for callback_shortcuts.0.dart API example. (flutter/flutter#147536)
2024-05-07 barpac02@gmail.com Improve Android SDK and NDK mistmatch warning message (flutter/flutter#147809)
2024-05-07 sokolovskyi.konstantin@gmail.com Add tests for shortcuts.dart API examples. (flutter/flutter#147433)
2024-05-07 sosamaalirizvi@gmail.com Added missing tests for ButtonStyle example (flutter/flutter#147457)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from ece1d686e3ba to 150f694a7816 (1 revision) (flutter/flutter#147912)
2024-05-07 leroux_bruno@yahoo.fr DropdownMenu cleanup (flutter/flutter#147860)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 80470584e1e1 to ece1d686e3ba (1 revision) (flutter/flutter#147910)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b7bfd94af743 to 80470584e1e1 (1 revision) (flutter/flutter#147906)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from b64e2300bcd0 to b7bfd94af743 (1 revision) (flutter/flutter#147905)
2024-05-07 zeqinjie@qq.com fix MenuItemButton if child is null  (flutter/flutter#147485)
2024-05-07 gspencergoog@users.noreply.github.com Fix document generation, eliminate template support from snippets tool. (flutter/flutter#147893)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 4cb9e02c06ce to b64e2300bcd0 (1 revision) (flutter/flutter#147904)
2024-05-07 82763757+NobodyForNothing@users.noreply.github.com test focus example 0 (flutter/flutter#147564)
2024-05-07 engine-flutter-autoroll@skia.org Roll Flutter Engine from 422f92b992c5 to 4cb9e02c06ce (1 revision) (flutter/flutter#147899)
2024-05-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147896)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 463ff7d2d4d5 to 422f92b992c5 (5 revisions) (flutter/flutter#147895)
2024-05-06 59215665+davidhicks980@users.noreply.github.com MultiSelectableSelectionContainerDelegate documentation fixes. (flutter/flutter#147843)
2024-05-06 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147891)
2024-05-06 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.4 to 4.1.5 (flutter/flutter#147888)
2024-05-06 32538273+ValentinVignal@users.noreply.github.com Fix janks and memory leaks in `CupertinoPageTransition` and `CupertinoFullscreenDialogTransition` (flutter/flutter#146999)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 960a0c8fecbe to 463ff7d2d4d5 (1 revision) (flutter/flutter#147886)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from 70cc300f9ad8 to 960a0c8fecbe (1 revision) (flutter/flutter#147884)
2024-05-06 jonahwilliams@google.com [new gallery] Reisze gallery images (flutter/flutter#147882)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from d0f99b35eac6 to 70cc300f9ad8 (1 revision) (flutter/flutter#147880)
2024-05-06 polinach@google.com Fix leak in a test. (flutter/flutter#147846)
2024-05-06 engine-flutter-autoroll@skia.org Roll Flutter Engine from a30ae7729c95 to d0f99b35eac6 (3 revisions) (flutter/flutter#147878)
2024-05-06 engine-flutter-autoroll@skia.org Roll Packages from f4719ca to 2dfe645 (3 revisions) (flutter/flutter#147866)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC bmparr@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmc justinmc justinmc approved these changes

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

@QuncCccccc QuncCccccc QuncCccccc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@osama383 @justinmc @Renzo-Olivares @QuncCccccc @bleroux